From: Jan Beulich Subject: x86/shadow: correct an inverted conditional in dirty VRAM tracking This originally was "mfn_x(mfn) == INVALID_MFN". Make it like this again, taking the opportunity to also drop the unnecessary nearby braces. This is XSA-319. Fixes: 246a5a3377c2 ("xen: Use a typesafe to define INVALID_MFN") Signed-off-by: Jan Beulich Reviewed-by: Andrew Cooper --- a/xen/arch/x86/mm/shadow/common.c +++ b/xen/arch/x86/mm/shadow/common.c @@ -3252,10 +3252,8 @@ int shadow_track_dirty_vram(struct domai int dirty = 0; paddr_t sl1ma = dirty_vram->sl1ma[i]; - if ( !mfn_eq(mfn, INVALID_MFN) ) - { + if ( mfn_eq(mfn, INVALID_MFN) ) dirty = 1; - } else { page = mfn_to_page(mfn);